Add tonemapping switch to bloom 2d example #17789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
reviewed
Feb 11, 2025
rparrett
reviewed
Feb 11, 2025
rparrett
added
A-Rendering
alice-i-cecile
added
C-Testing
rparrett
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Nice, this seems useful beyond the debugging you were using it for. I played with this once a while back when I was trying to figure out if bloom would work for one of my games.
I don't want to nitpick this to death. I could follow up with the other suggestions later, but we should fix the outdated comment.
|
I'm not a huge fan of this, personally. The example should be for demonstrating bloom, not tonemapping. |
but tonemapping affects the appearance of bloom, wouldn't it be important for the user to see the difference? |
alice-i-cecile
approved these changes
Feb 11, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow switching through available Tonemapping algorithms on
bloom_2dexample to compare between themSolution
Add a resource to
bloom_2dthat holds current tonemapping algorithm, a method to get the next one, and a check of key press to make the switchTesting
Ran
bloom_2dexample with modified codeShowcase
https://github.com/user-attachments/assets/920b2d6a-b237-4b19-be9d-9b651b4dc913
Note: Sprite flashing is already described in #17763